drm/panfrost: Make sure MMU context lifetime is not bound to panfrost_priv

Browse source

Jobs can be in-flight when the file descriptor is closed (either because
the process did not terminate properly, or because it didn't wait for
all GPU jobs to be finished), and apparently panfrost_job_close() does
not cancel already running jobs. Let's refcount the MMU context object
so it's lifetime is no longer bound to the FD lifetime and running jobs
can finish properly without generating spurious page faults.

Reported-by: Icecream95 <ixn@keemail.me>
Fixes: 7282f7645d ("drm/panfrost: Implement per FD address spaces")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210621133907.1683899-2-boris.brezillon@collabora.com

...

This commit is contained in:

Boris Brezillon 2021-06-21 15:38:56 +02:00

parent 7601d53c2c

commit 7fdc48cc63

6 changed files with 136 additions and 111 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/gpu/drm/panfrost/panfrost_device.h

View file

50

drivers/gpu/drm/panfrost/panfrost_drv.c

View file

20

drivers/gpu/drm/panfrost/panfrost_gem.c

View file

4

drivers/gpu/drm/panfrost/panfrost_job.c

View file

160

drivers/gpu/drm/panfrost/panfrost_mmu.c

View file

5

drivers/gpu/drm/panfrost/panfrost_mmu.h

View file