accel/habanalabs: use a mutex rather than a spinlock

Browse source

There are two reasons why mutex is better here:
1. There's a critical section relatively long, where in
certain scenarios (e.g., multiple VM allocations) taking a spinlock
might cause noticeable performance degradation.
2. It will remove the incorrect usage of mutex under
spin_lock (where preemption is disabled).

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

...

This commit is contained in:

Koby Elbaz 2023-02-23 18:17:02 +02:00 • committed by Oded Gabbay

parent c7ac65c881

commit 7ffb5ced2b

2 changed files with 10 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

15

drivers/accel/habanalabs/common/debugfs.c

View file

4

drivers/accel/habanalabs/common/habanalabs.h

View file