usb: usb_storage: do not align length of request for CBW to maxp size

Browse source

Mass-storage and file-storage gadgets align the length to maximum-packet-size
when preparing the request to receive CBW. This is unnecessary and prevents the
controller driver from knowing that a short-packet is expected.

It is incorrect to set short_not_ok when preparing the request to receive CBW.
CBW will be a short-packet so short_not_ok must not be set.

This makes bh->bulk_out_intended_length unnecessary so it is also removed.

Signed-off-by: Mian Yousaf Kaukab <mian.yousaf.kaukab@stericsson.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

...

This commit is contained in:

Mian Yousaf Kaukab 2011-03-24 12:20:13 +01:00 • committed by Greg Kroah-Hartman

parent 088c64f812

commit 806e8f8fcc

3 changed files with 10 additions and 49 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

24

drivers/usb/gadget/f_mass_storage.c

View file

28

drivers/usb/gadget/file_storage.c

View file

7

drivers/usb/gadget/storage_common.c

View file