qlcnic: underflow in qlcnic_validate_max_tx_rings()

Browse source

This function checks the upper bound but it doesn't check for negative
numbers:

	if (txq > QLCNIC_MAX_TX_RINGS) {

I've solved this by making "txq" a u32 type.  I chose that because
->tx_count in the ethtool_channels struct is a __u32.

This bug was added in aa4a1f7df7 ('qlcnic: Enable Tx queue changes using
ethtool for 82xx Series adapter.').

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Dan Carpenter 2013-08-27 04:16:22 +03:00 • committed by David S. Miller

parent 823a19e0cf

commit 80b17be70b

2 changed files with 2 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/qlogic/qlcnic/qlcnic.h

View file

2

drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

View file