thermal: Validate new state in cur_state_store()

Browse source

[ Upstream commit c408b3d1d9 ]

In cur_state_store(), the new state of the cooling device is received
from user-space and is not validated by the thermal core but the same is
left for the individual drivers to take care of. Apart from duplicating
the code it leaves possibility for introducing bugs where a driver may
not do it right.

Lets make the thermal core check the new state itself and store the max
value in the cooling device structure.

Link: https://lore.kernel.org/all/Y0ltRJRjO7AkawvE@kili/
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Stable-dep-of: 6c54b7bc8a ("thermal: core: call put_device() only after device_register() fails")
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Viresh Kumar 2022-10-17 15:33:01 +05:30 • committed by Greg Kroah-Hartman

parent 3896f78b22

commit 80bb3b901a

4 changed files with 14 additions and 19 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/thermal/gov_fair_share.c

View file

15

drivers/thermal/thermal_core.c

View file

11

drivers/thermal/thermal_sysfs.c

View file

1

include/linux/thermal.h

View file