xfs: verify inline directory data forks

Browse source

commit 630a04e79d upstream.

When we're reading or writing the data fork of an inline directory,
check the contents to make sure we're not overflowing buffers or eating
garbage data.  xfs/348 corrupts an inline symlink into an inline
directory, triggering a buffer overflow bug.

v2: add more checks consistent with _dir2_sf_check and make the verifier
usable from anywhere.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Darrick J. Wong 2017-03-15 00:24:25 -07:00 • committed by Greg Kroah-Hartman

parent 11b4854772

commit 815414e764

6 changed files with 122 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

fs/xfs/libxfs/xfs_dir2_priv.h

View file

87

fs/xfs/libxfs/xfs_dir2_sf.c

View file

26

fs/xfs/libxfs/xfs_inode_fork.c

View file

2

fs/xfs/libxfs/xfs_inode_fork.h

View file

11

fs/xfs/xfs_dir2_readdir.c

View file

12

fs/xfs/xfs_inode.c

View file