drm/vc4: hdmi: Add a spinlock to protect register access

Browse source

The vc4 HDMI driver has multiple path shared between the CEC, ALSA and
KMS frameworks, plus two interrupt handlers (CEC and hotplug) that will
read and modify a number of registers.

Even though not bug has been reported so far, it's definitely unsafe, so
let's just add a spinlock to protect the register access of the HDMI
controller.

Link: https://lore.kernel.org/r/20211025141113.702757-5-maxime@cerno.tech
Fixes: c8b75bca92 ("drm/vc4: Add KMS support for Raspberry Pi.")
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>

...

This commit is contained in:

Maxime Ripard 2021-10-25 16:11:08 +02:00

parent eeb6ab4639

commit 81fb55e500

No known key found for this signature in database

GPG key ID: E3EF0D6F671851C5

4 changed files with 236 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

202

drivers/gpu/drm/vc4/vc4_hdmi.c

View file

5

drivers/gpu/drm/vc4/vc4_hdmi.h

View file

37

drivers/gpu/drm/vc4/vc4_hdmi_phy.c

View file

2

drivers/gpu/drm/vc4/vc4_hdmi_regs.h

View file