media: atomisp: Remove isp_timeout flag

Browse source

isp_timeout only ever gets set in __atomisp_css_recover() and then
immediately gets cleared again after calling atomisp_reset().

All this happens with isp->mutex held.

The only consumer of isp->isp_timeout is atomisp_stop_streaming(), which
also holds isp->mutex and which is *not* called by atomisp_reset().

Since both hold isp->mutex and since __atomisp_css_recover() clears
isp_timeout before releasing the mutex, atomisp_stop_streaming() can
never see isp_timeout being true, so just remove the flag.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

...

This commit is contained in:

Hans de Goede 2023-05-11 15:51:21 +01:00 • committed by Mauro Carvalho Chehab

parent fb86cf8bd8

commit 820a1338d6

3 changed files with 4 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

drivers/staging/media/atomisp/pci/atomisp_cmd.c

View file

2

drivers/staging/media/atomisp/pci/atomisp_internal.h

View file

7

drivers/staging/media/atomisp/pci/atomisp_ioctl.c

View file