diff --git a/include/net/tcp.h b/include/net/tcp.h index 96a1a23e47fa..74f54bfa51f1 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -3093,7 +3093,7 @@ enum skb_drop_reason tcp_inbound_hash(struct sock *sk, static inline int tcp_recv_should_stop(struct sock *sk) { - return sk->sk_err || + return READ_ONCE(sk->sk_err) || sk->sk_state == TCP_CLOSE || (sk->sk_shutdown & RCV_SHUTDOWN) || signal_pending(current); diff --git a/net/core/stream.c b/net/core/stream.c index 2d748581862d..5c0adc3077f0 100644 --- a/net/core/stream.c +++ b/net/core/stream.c @@ -133,7 +133,7 @@ int sk_stream_wait_memory(struct sock *sk, long *timeo_p) while (1) { sk_set_bit(SOCKWQ_ASYNC_NOSPACE, sk); - if (sk->sk_err || (sk->sk_shutdown & SEND_SHUTDOWN)) + if (READ_ONCE(sk->sk_err) || (sk->sk_shutdown & SEND_SHUTDOWN)) goto do_error; if (!*timeo_p) goto do_eagain; diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 3ac485685279..7c9d8305094c 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -846,10 +846,9 @@ ssize_t tcp_splice_read(struct socket *sock, loff_t *ppos, break; if (sock_flag(sk, SOCK_DONE)) break; - if (sk->sk_err) { - ret = sock_error(sk); + ret = sock_error(sk); + if (ret) break; - } if (sk->sk_shutdown & RCV_SHUTDOWN) break; if (sk->sk_state == TCP_CLOSE) { @@ -1230,7 +1229,7 @@ restart: mss_now = tcp_send_mss(sk, &size_goal, flags); err = -EPIPE; - if (sk->sk_err || (sk->sk_shutdown & SEND_SHUTDOWN)) + if (READ_ONCE(sk->sk_err) || (sk->sk_shutdown & SEND_SHUTDOWN)) goto do_error; while (msg_data_left(msg)) { @@ -2762,10 +2761,9 @@ static int tcp_recvmsg_locked(struct sock *sk, struct msghdr *msg, size_t len, if (sock_flag(sk, SOCK_DONE)) break; - if (sk->sk_err) { - copied = sock_error(sk); + copied = sock_error(sk); + if (copied) break; - } if (sk->sk_shutdown & RCV_SHUTDOWN) break; diff --git a/net/ipv4/tcp_bpf.c b/net/ipv4/tcp_bpf.c index 2e234d155b5e..338c5d90e550 100644 --- a/net/ipv4/tcp_bpf.c +++ b/net/ipv4/tcp_bpf.c @@ -286,10 +286,9 @@ msg_bytes_ready: if (sock_flag(sk, SOCK_DONE)) goto out; - if (sk->sk_err) { - copied = sock_error(sk); + copied = sock_error(sk); + if (copied) goto out; - } if (sk->sk_shutdown & RCV_SHUTDOWN) goto out; @@ -553,10 +552,9 @@ static int tcp_bpf_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) bool enospc = false; u32 copy, osize; - if (sk->sk_err) { - err = -sk->sk_err; + err = -READ_ONCE(sk->sk_err); + if (err) goto out_err; - } copy = msg_data_left(msg); if (!sk_stream_memory_free(sk)) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index e89a69ab927c..b543eb245136 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -970,7 +970,7 @@ static bool move_skbs_to_msk(struct mptcp_sock *msk, struct sock *ssk) moved = __mptcp_move_skbs_from_subflow(msk, ssk, true); __mptcp_ofo_queue(msk); - if (unlikely(ssk->sk_err)) + if (unlikely(READ_ONCE(ssk->sk_err))) __mptcp_subflow_error_report(sk, ssk); /* If the moves have caught up with the DATA_FIN sequence number @@ -2033,7 +2033,7 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) } ret = -EPIPE; - if (unlikely(sk->sk_err || (sk->sk_shutdown & SEND_SHUTDOWN))) + if (unlikely(READ_ONCE(sk->sk_err) || (sk->sk_shutdown & SEND_SHUTDOWN))) goto do_error; pfrag = sk_page_frag(sk); @@ -2434,10 +2434,9 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, !timeo) break; } else { - if (sk->sk_err) { - copied = sock_error(sk); + copied = sock_error(sk); + if (copied) break; - } if (sk->sk_shutdown & RCV_SHUTDOWN) break; @@ -4671,10 +4670,9 @@ static ssize_t mptcp_splice_read(struct socket *sock, loff_t *ppos, break; if (sock_flag(sk, SOCK_DONE)) break; - if (sk->sk_err) { - ret = sock_error(sk); + ret = sock_error(sk); + if (ret) break; - } if (sk->sk_shutdown & RCV_SHUTDOWN) break; if (sk->sk_state == TCP_CLOSE) { diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 14aa82647c3d..e9cb19188069 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -1545,7 +1545,7 @@ static void subflow_data_ready(struct sock *sk) if (mptcp_data_avail(msk) < parent->sk_rcvlowat && (tcp_sk(sk)->rcv_nxt - tcp_sk(sk)->rcv_wup) > inet_csk(sk)->icsk_ack.rcv_mss) inet_csk(sk)->icsk_ack.pending |= ICSK_ACK_NOW; - } else if (unlikely(sk->sk_err)) { + } else if (unlikely(READ_ONCE(sk->sk_err))) { subflow_error_report(sk); } } @@ -1900,7 +1900,7 @@ static void subflow_state_change(struct sock *sk) */ if (mptcp_subflow_data_available(sk)) mptcp_data_ready(parent, sk); - else if (unlikely(sk->sk_err)) + else if (unlikely(READ_ONCE(sk->sk_err))) subflow_error_report(sk); subflow_sched_work_if_closed(mptcp_sk(parent), sk);