drm/amdgpu: fix calltrace during kmd unload(v3)

Browse source

issue:
kernel would report a warning from a double unpin
during the driver unloading on the CSB bo

why:
we unpin it during hw_fini, and there will be another
unpin in sw_fini on CSB bo.

fix:
actually we don't need to pin/unpin it during
hw_init/fini since it is created with kernel pinned,
we only need to fullfill the CSB again during hw_init
to prevent CSB/VRAM lost after S3

v2:
get_csb in init_rlc so hw_init() will make CSIB content
back even after reset or s3

v3:
use bo_create_kernel instead of bo_create_reserved for CSB
otherwise the bo_free_kernel() on CSB is not aligned and
would lead to its internal reserve pending there forever

take care of gfx7/8 as well

Signed-off-by: Monk Liu <Monk.Liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Monk Liu 2019-11-26 19:42:25 +08:00 • committed by Alex Deucher

parent 5bbbc9b778

commit 82a829dc8c

5 changed files with 6 additions and 144 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c

View file

58

drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c

View file

2

drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c

View file

40

drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

View file

40

drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

View file