drm/msm/dpu: Move autorefresh disable from CMD encoder to pingpong

Browse source

[ Upstream commit 4a7c38ec7d ]

This autorefresh disable logic in the physical command-mode encoder
consumes three callbacks to the pingpong block, and will explode in
unnecessary complexity when the same callbacks need to be called on the
interface block instead to accommodate INTF TE support.  To clean this
up, move the logic into the pingpong block under a disable_autorefresh
callback, replacing the aforementioned three get_autorefresh,
setup_autorefresh and get_vsync_info callbacks.

The same logic will have to be replicated to the interface block when it
receives INTF TE support, but it is less complex than constantly
switching on a "has_intf_te" boolean to choose a callback.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/534230/
Link: https://lore.kernel.org/r/20230411-dpu-intf-te-v4-13-27ce1a5ab5c6@somainline.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Stable-dep-of: 0b78be614c ("drm/msm/dpu: fix sc7280 and sc7180 PINGPONG done interrupts")
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Marijn Suijten 2023-04-27 00:37:27 +02:00 • committed by Greg Kroah-Hartman

parent d06fc6c07b

commit 82aaea40aa

4 changed files with 57 additions and 79 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

60

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

View file

47

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c

View file

27

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h

View file

4

drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h

View file