drm/i915: Compute the HWS offsets explicitly

Browse source

Simplify by using sizeof(u32) to convert from the index inside the HWSP
to the byte offset. This has the advantage of not only being shorter
(and so not upsetting checkpatch!) but that it matches use where we are
writing to byte addresses using other commands than MI_STORE_DWORD_IMM.

v2: Drop the now superfluous MI_STORE_DWORD_INDEX_SHIFT, it appears to
be a local invention so keeping it after the final use does not help to
clarify the GPU instruction.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190125120005.25191-2-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2019-01-25 12:00:05 +00:00

parent 9fa4973e91

commit 832a67bdb2

3 changed files with 7 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

drivers/gpu/drm/i915/intel_gpu_commands.h

View file

4

drivers/gpu/drm/i915/intel_guc_submission.c

View file

10

drivers/gpu/drm/i915/intel_ringbuffer.h

View file