crypto: api - check for ERR pointers in crypto_destroy_tfm()

Browse source

Given that crypto_alloc_tfm() may return ERR pointers, and to avoid
crashes on obscure error paths where such pointers are presented to
crypto_destroy_tfm() (such as [0]), add an ERR_PTR check there
before dereferencing the second argument as a struct crypto_tfm
pointer.

[0] https://lore.kernel.org/linux-crypto/000000000000de949705bc59e0f6@google.com/

Reported-by: syzbot+12cf5fbfdeba210a89dd@syzkaller.appspotmail.com
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

...

This commit is contained in:

Ard Biesheuvel 2021-03-02 21:33:03 +01:00 • committed by Herbert Xu

parent 98b5ef3e97

commit 83681f2beb

8 changed files with 17 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

include/crypto/acompress.h

View file

2

include/crypto/aead.h

View file

2

include/crypto/akcipher.h

View file

4

include/crypto/hash.h

View file

2

include/crypto/kpp.h

View file

2

include/crypto/rng.h

View file

2

include/crypto/skcipher.h

View file