From 843b525180463162f484bec2cd9fa0e13599fa5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timur=20Krist=C3=B3f?= Date: Fri, 4 Sep 2026 20:34:09 +0200 Subject: [PATCH] drm/amdgpu: Delete unimplemented DM soft_reset() code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The soft_reset() function for the DCE / DCN blocks has never been implemented, and there are no plans to implement it. Let's delete this function, it doesn't do anything and also isn't called from anywhere. Acked-by: Christian König Signed-off-by: Timur Kristóf Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 -------- .../drm/amd/display/amdgpu_dm/tests/amdgpu_dm_test.c | 10 ---------- 2 files changed, 18 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index bc4566818676..74cead576e46 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -233,13 +233,6 @@ VISIBLE_IF_KUNIT int dm_wait_for_idle(struct amdgpu_ip_block *ip_block) } EXPORT_SYMBOL_IF_KUNIT(dm_wait_for_idle); -VISIBLE_IF_KUNIT int dm_soft_reset(struct amdgpu_ip_block *ip_block) -{ - /* XXX todo */ - return 0; -} -EXPORT_SYMBOL_IF_KUNIT(dm_soft_reset); - /* * DC will program planes with their z-order determined by their ordering * in the dc_surface_updates array. This comparator is used to sort them @@ -2143,7 +2136,6 @@ static const struct amd_ip_funcs amdgpu_dm_funcs = { .suspend = dm_suspend, .resume = dm_resume, .wait_for_idle = dm_wait_for_idle, - .soft_reset = dm_soft_reset, .set_clockgating_state = dm_set_clockgating_state, .set_powergating_state = dm_set_powergating_state, }; diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_test.c b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_test.c index 7170723d98ce..c56829de66fc 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_test.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_test.c @@ -49,15 +49,6 @@ static void dm_test_wait_for_idle(struct kunit *test) KUNIT_EXPECT_EQ(test, dm_wait_for_idle(NULL), 0); } -/** - * dm_test_soft_reset - Test placeholder soft-reset callback returns success - * @test: The KUnit test context - */ -static void dm_test_soft_reset(struct kunit *test) -{ - KUNIT_EXPECT_EQ(test, dm_soft_reset(NULL), 0); -} - /** * dm_test_set_clockgating_state - Test placeholder clockgating callback returns success * @test: The KUnit test context @@ -5217,7 +5208,6 @@ static void dm_test_gpureset_toggle_interrupts_dcn(struct kunit *test) static struct kunit_case amdgpu_dm_tests[] = { /* Simple DM callbacks */ KUNIT_CASE(dm_test_wait_for_idle), - KUNIT_CASE(dm_test_soft_reset), KUNIT_CASE(dm_test_set_clockgating_state), KUNIT_CASE(dm_test_set_powergating_state), KUNIT_CASE(dm_test_bandwidth_update),