drm: rcar-du: Handle primary plane config through atomic plane ops

Browse source

Use the new CRTC atomic transitional helpers drm_helper_crtc_mode_set()
and drm_helper_crtc_mode_set_base() to implement the CRTC .mode_set and
.mode_set_base operations. This delegates primary plane configuration to
the plane .atomic_update and .atomic_disable operations, removing
duplicate code from the CRTC implementation.

There is now no code path available to the driver in which to drop the
reference to the CRTC acquired in the .prepare() operation if an error
then occurs. The driver thus now leaks a reference if an error occurs
during mode set. So be it, this will be fixed in a further step of the
atomic update transition.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

...

This commit is contained in:

Laurent Pinchart 2015-02-18 15:47:27 +02:00

parent 920888a2d5

commit 845f46356b

3 changed files with 14 additions and 78 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

81

drivers/gpu/drm/rcar-du/rcar_du_crtc.c

View file

8

drivers/gpu/drm/rcar-du/rcar_du_plane.c

View file

3

drivers/gpu/drm/rcar-du/rcar_du_plane.h

View file