media: atomisp: print a better message when fw version is wrong

Browse source

The printed message when a firmware version is wrong says nothing
usefull:

	atomisp-isp2 0000:00:03.0: Fw version check failed.
	atomisp-isp2: probe of 0000:00:03.0 failed with error -22

Print the expected and the received firmware version instead.

In order to do that, the firmware functions will need at least
a struct device pointer, so pass it.

While writing this patch, it was noticed that some of the
abstraction layers of this driver have functions that are never
called, but use this interface. Get rid of them.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

...

This commit is contained in:

Mauro Carvalho Chehab 2020-05-07 18:33:29 +02:00

parent 1ab709827c

commit 8568fe6300

6 changed files with 21 additions and 134 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

View file

35

drivers/staging/media/atomisp/pci/ia_css_control.h

View file

12

drivers/staging/media/atomisp/pci/ia_css_firmware.h

View file

87

drivers/staging/media/atomisp/pci/sh_css.c

View file

8

drivers/staging/media/atomisp/pci/sh_css_firmware.c

View file

4

drivers/staging/media/atomisp/pci/sh_css_firmware.h

View file