ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control()

Browse source

The error handling frees "ctl" but it's still on the "dsp->ctl_list"
list so that could result in a use after free.  Remove it from the list
before returning.

Fixes: 2323736dca ("ASoC: wm_adsp: Add basic support for rev 1 firmware file format")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/X9B0keV/02wrx9Xs@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Dan Carpenter 2020-12-09 09:54:09 +03:00 • committed by Mark Brown

parent 718c406e1f

commit 85a7555575

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 3 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

sound/soc/codecs/wm_adsp.c

View file