net/sonic: Add mutual exclusion for accessing shared state

Browse source

The netif_stop_queue() call in sonic_send_packet() races with the
netif_wake_queue() call in sonic_interrupt(). This causes issues
like "NETDEV WATCHDOG: eth0 (macsonic): transmit queue 0 timed out".
Fix this by disabling interrupts when accessing tx_skb[] and next_tx.
Update a comment to clarify the synchronization properties.

Fixes: efcce83936 ("[PATCH] macsonic/jazzsonic network drivers update")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Finn Thain 2020-01-23 09:07:26 +11:00 • committed by David S. Miller

parent 457bfc0a4b

commit 865ad2f220

2 changed files with 36 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

49

drivers/net/ethernet/natsemi/sonic.c

View file

1

drivers/net/ethernet/natsemi/sonic.h

View file