xfs: factor xfs_da3_blkinfo verification into common helper

Browse source

With the verifier magic value helper in place, we've left a bit more
duplicate code across the verifiers that involve struct
xfs_da3_blkinfo. This includes the da node, xattr leaf and dir leaf
verifiers, all of which perform similar checks for v4 and v5
filesystems.

Create a common helper to verify an xfs_da3_blkinfo structure,
taking care to only access v5 fields where appropriate, and refactor
the aforementioned verifiers to use the helper. No functional
changes.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

...

This commit is contained in:

Brian Foster 2019-02-07 10:45:48 -08:00 • committed by Darrick J. Wong

parent 39708c20ab

commit 8764f98351

4 changed files with 43 additions and 37 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

fs/xfs/libxfs/xfs_attr_leaf.c

View file

44

fs/xfs/libxfs/xfs_da_btree.c

View file

3

fs/xfs/libxfs/xfs_da_format.h

View file

17

fs/xfs/libxfs/xfs_dir2_leaf.c

View file