[POWERPC] spufs: Fix gang destroy leaks

Browse source

Previously, closing a SPE gang that still has contexts would trigger
a WARN_ON, and leak the allocated gang.

This change fixes the problem by using the gang's reference counts to
destroy the gang instead. The gangs will persist until their last
reference (be it context or open file handle) is gone.

Also, avoid using statements with side-effects in a WARN_ON().

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

...

This commit is contained in:

Jeremy Kerr 2007-06-04 23:26:51 +10:00 • committed by Paul Mackerras

parent ce92987bab

commit 877907d37d

1 changed files with 5 additions and 35 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

40

arch/powerpc/platforms/cell/spufs/inode.c

View file