amd-xgbe: Perform phy connect/disconnect at dev open/stop

Browse source

A change added to the mdiobus/phy api added a module_get/module_put
during phy connect/disconnect processing. Currently, the driver
performs a phy connect during module probe and a phy disconnect during
module remove. With the addition of the module_get during phy connect
the amd-xgbe module use count is incremented and can no longer be
unloaded.

Move the phy connect/disconnect from the driver probe/remove functions
to the net_device_ops ndo_open/ndo_stop functions.  This allows the
module use count to be decremented when the device(s) are brought down
and allows the module to be unloaded.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Lendacky, Thomas 2014-08-05 13:30:44 -05:00 • committed by David S. Miller

parent f3d0e78d2e

commit 88131a812b

2 changed files with 121 additions and 99 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

122

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

View file

98

drivers/net/ethernet/amd/xgbe/xgbe-mdio.c

View file