drm/i915: Use container_of_const() for states

Browse source

commit 64f6a5d192 ("container_of: add container_of_const()
that preserves const-ness of the pointer") is nice. Let's use
it so that we don't accidentally cast away the const from our
state pointers.

The only thing I don't particularly like about container_of_const()
is that it still accepts void* in addition to the proper pointer
types, but that's how most other things in C work anyway so I
guess we can live with it.

And while at it rename the macro arguments to be a bit more
descriptive than just 'x'.

TODO: maybe convert *all* container_of() uses to container_of_const()?

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240307151810.24208-4-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>

...

This commit is contained in:

Ville Syrjälä 2024-03-07 17:18:09 +02:00

parent 7e0c5caf94

commit 89164fc86e

7 changed files with 23 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/i915/display/intel_bw.h

View file

4

drivers/gpu/drm/i915/display/intel_cdclk.h

View file

14

drivers/gpu/drm/i915/display/intel_display_types.h

View file

5

drivers/gpu/drm/i915/display/intel_pmdemand.h

View file

2

drivers/gpu/drm/i915/display/intel_sdvo.c

View file

3

drivers/gpu/drm/i915/display/intel_tv.c

View file

4

drivers/gpu/drm/i915/display/skl_watermark.h

View file