x86/insn,uprobes,alternative: Unify insn_is_nop()

Browse source

Both uprobes and alternatives have insn_is_nop() variants, unify them
and make sure insn_is_nop() works for both x86_64 and i386.

Specifically, uprobe must not compare userspace instructions to kernel
nops as that does not work right in the compat case.

For the uprobe case we therefore must recognise common 32bit and 64bit
nops. Because uprobe will consume the instruction as a nop, it must
not mistakenly claim a non-nop instruction to be a nop. Eg. 'REX.b3
NOP' is 'xchg %r8,%rax' - not a nop.

For the kernel case similar constraints apply, is it used to optimize
NOPs by replacing strings of short(er) nops with longer nops. Must not
claim an instruction is a nop if it really isn't. Not recognising a
nop is non-fatal.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

...

This commit is contained in:

Peter Zijlstra 2025-09-05 10:24:47 +02:00

parent 866cf36bfe

commit 8a5c6cbfe4

4 changed files with 151 additions and 48 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/x86/include/asm/insn-eval.h

View file

20

arch/x86/kernel/alternative.c

View file

32

arch/x86/kernel/uprobes.c

View file

145

arch/x86/lib/insn-eval.c

View file