pwm: vt8500: Register write busy test performed incorrectly

Browse source

Correct operation for register writes is to perform a busy-wait
after writing the register. Currently the busy wait it performed
before, meaning subsequent register writes to bitfields may occur
before the previous field has been updated.

Also, all registers are defined as 32-bit read/write. Change
pwm_busy_wait() to use readl rather than readb.

Improve readability of code with defines for registers and bitfields.

Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>

...

This commit is contained in:

Tony Prisk 2013-01-03 08:44:15 +13:00 • committed by Thierry Reding

parent 9421bade07

commit 8ab432caa4

1 changed files with 49 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

64

drivers/pwm/pwm-vt8500.c

View file