ovl: narrow locking in ovl_whiteout()

Browse source

ovl_whiteout() relies on the workdir i_rwsem to provide exclusive access
to ofs->whiteout which it manipulates.  Rather than depending on this,
add a new mutex, "whiteout_lock" to explicitly provide the required
locking.  Use guard(mutex) for this so that we can return without
needing to explicitly unlock.

Then take the lock on workdir only when needed - to lookup the temp name
and to do the whiteout or link.

Signed-off-by: NeilBrown <neil@brown.name>
Link: https://lore.kernel.org/20250716004725.1206467-19-neil@brown.name
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>

...

This commit is contained in:

NeilBrown 2025-07-16 10:44:29 +10:00 • committed by Christian Brauner

parent 2fa14cf2dc

commit 8afa0a7367

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

3 changed files with 27 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

46

fs/overlayfs/dir.c

View file

1

fs/overlayfs/ovl_entry.h

View file

2

fs/overlayfs/params.c

View file