perf dwarf-aux: Skip check_variable for variable lookup

Browse source

Both die_find_variable_by_reg and die_find_variable_by_addr call
match_var_offset which already performs sufficient checking and type
matching. The additional check_variable call is redundant, and its
need_pointer logic is only a heuristic. Since DWARF encodes accurate
type information, which match_var_offset verifies, skipping
check_variable improves both coverage and accuracy.

Return the matched type from die_find_variable_by_reg and
die_find_variable_by_addr via the existing `type` field in
find_var_data, removing the need for check_variable in
find_data_type_die.

Signed-off-by: Zecheng Li <zecheng@google.com>
Signed-off-by: Zecheng Li <zli94@ncsu.edu>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

...

This commit is contained in:

Zecheng Li 2026-03-09 13:55:16 -04:00 • committed by Namhyung Kim

parent ace1630317

commit 8b8d8b8f17

3 changed files with 30 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

42

tools/perf/util/annotate-data.c

View file

13

tools/perf/util/dwarf-aux.c

View file

5

tools/perf/util/dwarf-aux.h

View file