selftests/bpf: set BPF_F_TEST_SANITY_SCRIPT by default

Browse source

Make sure to set BPF_F_TEST_SANITY_STRICT program flag by default across
most verifier tests (and a bunch of others that set custom prog flags).

There are currently two tests that do fail validation, if enforced
strictly: verifier_bounds/crossing_64_bit_signed_boundary_2 and
verifier_bounds/crossing_32_bit_signed_boundary_2. To accommodate them,
we teach test_loader a flag negation:

__flag(!<flagname>) will *clear* specified flag, allowing easy opt-out.

We apply __flag(!BPF_F_TEST_SANITY_STRICT) to these to tests.

Also sprinkle BPF_F_TEST_SANITY_STRICT everywhere where we already set
test-only BPF_F_TEST_RND_HI32 flag, for completeness.

Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20231112010609.848406-12-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

...

This commit is contained in:

Andrii Nakryiko 2023-11-11 17:06:07 -08:00 • committed by Alexei Starovoitov

parent dab16659c5

commit 8c5677f8b3

6 changed files with 33 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

tools/testing/selftests/bpf/prog_tests/bpf_verif_scale.c

View file

2

tools/testing/selftests/bpf/progs/verifier_bounds.c

View file

35

tools/testing/selftests/bpf/test_loader.c

View file

1

tools/testing/selftests/bpf/test_sock_addr.c

View file

2

tools/testing/selftests/bpf/test_verifier.c

View file

4

tools/testing/selftests/bpf/testing_helpers.c

View file