wifi: rtlwifi: rtl8192cu: Fix TX aggregation

Browse source

rtl8192cu is checking rtl_mac.tids when deciding if it should enable
aggregation. This is wrong because rtl_mac.tids is not initialised
anywhere. Check rtl_sta_info.tids instead, which is initialised.

Also, when enabling aggregation also enable RTS. The vendor driver does
this, my router does this. It seems like the thing to do.

Also also, it seems right to set the AMPDU density only when enabling
aggregation.

Also also also, delete the unused member rtl_mac.tids and the unused
macros RTL_AGG_ON and RTL_AGG_OFF.

Naturally, with working AMPDU the download/upload speeds are better.
Before: 59/32 Mbps.
After:  68/46 Mbps.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/4e936334-5f81-403f-a495-0628ebfb6903@gmail.com

...

This commit is contained in:

Bitterblue Smith 2024-02-15 20:57:59 +02:00 • committed by Kalle Valo

parent 00413dd364

commit 8ca4cdef93

3 changed files with 17 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

29

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c

View file

2

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h

View file

3

drivers/net/wireless/realtek/rtlwifi/wifi.h

View file