habanalabs: adjust pci controller init to new firmware

Browse source

[ Upstream commit 377182a3cc ]

When the firmware security is enabled, the pcie_aux_dbi_reg_addr
register in the PCI controller is blocked. Therefore, ignore
the result of writing to this register and assume it worked. Also
remove the prints on errors in the internal ELBI write function.

If the security is enabled, the firmware is responsible for setting
this register correctly so we won't have any problem.

If the security is disabled, the write will work (unless something
is totally broken at the PCI level and then the whole sequence
will fail).

In addition, remove a write to register pcie_aux_dbi_reg_addr+4,
which was never actually needed.

Moreover, PCIE_DBI registers are blocked to access from host when
firmware security is enabled. Use a different register to flush the
writes.

Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Oded Gabbay 2020-12-09 19:50:46 +02:00 • committed by Greg Kroah-Hartman

parent 06b0d83b33

commit 8d0522d968

3 changed files with 21 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

drivers/misc/habanalabs/common/pci.c

View file

4

drivers/misc/habanalabs/gaudi/gaudi.c

View file

3

drivers/misc/habanalabs/gaudi/gaudi_coresight.c

View file