ASoC: rt5651: Fix workqueue cancel vs irq free race on remove

Browse source

On removal we must free the IRQ *before* cancelling the jack-detect work,
so that the jack-detect work cannot be rescheduled by the IRQ.

Before this commit we were cancelling the jack-detect work from the
driver remove callback, while relying on devm to free the IRQ, which
happens after the remove callback.

This is the wrong order. This commit uses a devm-action to register
a devm callback which cancels the work, before requesting the IRQ
(devm tears things down in reverse order). This also allows us to
remove the now empty remove driver callback.

Cc: Carlo Caione <carlo@endlessm.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Hans de Goede 2018-07-05 00:59:31 +02:00 • committed by Mark Brown

parent 5f6fb23d2e

commit 8d2d7bcdc1

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 12 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

22

sound/soc/codecs/rt5651.c

View file