ASoC: bcm2835: fix hw_params error when device is in prepared state

Browse source

If bcm2835 is configured as bitclock master calling hw_params()
after prepare() fails with EBUSY. This also makes it impossible to
use bcm2835 in full duplex mode.

The error is caused by the split clock setup: clk_set_rate
is called in hw_params, clk_prepare_enable in prepare. As hw_params
doesn't check if the clock was already enabled clk_set_rate
fails with EBUSY.

Fix this by moving clock startup from prepare to hw_params and
let hw_params properly deal with an already set up or enabled
clock.

Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Matthias Reichl 2018-01-17 13:50:50 +01:00 • committed by Mark Brown

parent 4fbd8d194f

commit 8d5737a5f5

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 14 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

sound/soc/bcm/bcm2835-i2s.c

View file