iwlwifi: pcie: remove TR/CR tail allocations

Browse source

The TR/CR tail data are meant to be per-queue-arrays, however,
we allocate them completely wrong (we have a separate allocation
per queue).

Looking at this more closely, it turns out that the hardware
never uses these - we have a separate free list per RX queue
and maintain a write pointer for that in a register, and the
RX itself is indicated in the RB status (rb_stts) DMA region.

Despite nothing using the tail pointers, the hardware will
unconditionally access them to write updates, even when we aren't
using CRs/TRs.

Give it dummy values that we never use/update so it can do that
without causing trouble.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20210617110647.5f5764e04c46.I4d5de1929be048085767f1234a1e07b517ab6a2d@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

...

This commit is contained in:

Johannes Berg 2021-06-17 11:07:28 +03:00 • committed by Luca Coelho

parent bef99c7d91

commit 8e08e191fc

3 changed files with 14 additions and 59 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info-gen3.c

View file

11

drivers/net/wireless/intel/iwlwifi/pcie/internal.h

View file

34

drivers/net/wireless/intel/iwlwifi/pcie/rx.c

View file