From 8eaff52fc101c1f6b3215db93bba02c815155806 Mon Sep 17 00:00:00 2001 From: Koichiro Den Date: Thu, 19 Feb 2026 23:56:33 +0900 Subject: [PATCH] PCI: endpoint: pci-epf-vntb: Return -ERANGE for out-of-range MW index The mw1..mw4 configfs attributes are only valid when the MW index is within the configured num_mws range. Return -ERANGE instead of -EINVAL when a configfs MW size attribute is accessed with an out-of-range MW index. Suggested-by: Manivannan Sadhasivam Signed-off-by: Koichiro Den Signed-off-by: Manivannan Sadhasivam Link: https://patch.msgid.link/20260219145633.4191325-1-den@valinux.co.jp --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 71a35f575cc1..148a3b160812 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1004,7 +1004,7 @@ static ssize_t epf_ntb_##_name##_show(struct config_item *item, \ if (idx < 0 || idx >= ntb->num_mws) { \ dev_err(dev, "MW%d out of range (num_mws=%d)\n", \ win_no, ntb->num_mws); \ - return -EINVAL; \ + return -ERANGE; \ } \ idx = array_index_nospec(idx, ntb->num_mws); \ return sprintf(page, "%llu\n", ntb->mws_size[idx]); \ @@ -1032,7 +1032,7 @@ static ssize_t epf_ntb_##_name##_store(struct config_item *item, \ if (idx < 0 || idx >= ntb->num_mws) { \ dev_err(dev, "MW%d out of range (num_mws=%d)\n", \ win_no, ntb->num_mws); \ - return -EINVAL; \ + return -ERANGE; \ } \ idx = array_index_nospec(idx, ntb->num_mws); \ ntb->mws_size[idx] = val; \