scsi: hisi_sas: use wait_for_completion_timeout() when clearing ITCT

Browse source

When injecting 2bit ecc errors, it will cause confusion inside SAS
controller which needs host reset to recover it. If a device is gone at the
same times inject 2bit ecc errors, we may not receive the ITCT interrupt so
it will wait for completion in clear_itct_v3_hw() all the time. And host
reset will also not occur because it can't require hisi_hba->sem, so the
system will be suspended.

To solve the issue, use wait_for_completion_timeout() instead of
wait_for_completion(), and also don't mark the gone device as
SAS_PHY_UNUSED when device gone.

Link: https://lore.kernel.org/r/1571926105-74636-4-git-send-email-john.garry@huawei.com
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

...

This commit is contained in:

Xiang Chen 2019-10-24 22:08:10 +08:00 • committed by Martin K. Petersen

parent 65a3b8bd56

commit 8fa9a7bd30

5 changed files with 33 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/scsi/hisi_sas/hisi_sas.h

View file

8

drivers/scsi/hisi_sas/hisi_sas_main.c

View file

6

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

View file

13

drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

View file

13

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

View file