From 901e581bfc44d181f7d9c3f11880dac3e89deb2e Mon Sep 17 00:00:00 2001 From: Qu Wenruo Date: Tue, 3 Mar 2026 09:45:22 +0800 Subject: [PATCH] btrfs: send: check for inline extents in range_is_hole_in_parent() [ Upstream commit 08b096c1372cd69627f4f559fb47c9fb67a52b39 ] Before accessing the disk_bytenr field of a file extent item we need to check if we are dealing with an inline extent. This is because for inline extents their data starts at the offset of the disk_bytenr field. So accessing the disk_bytenr means we are accessing inline data or in case the inline data is less than 8 bytes we can actually cause an invalid memory access if this inline extent item is the first item in the leaf or access metadata from other items. Fixes: 82bfb2e7b645 ("Btrfs: incremental send, fix unnecessary hole writes for sparse files") Reviewed-by: Filipe Manana Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba [ Avoid leaking the path by using { ret = 0; goto out; } instead of returning directly. ] Signed-off-by: Alva Lan Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/send.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index a46076788bd7..68c62b34d6f0 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -5892,6 +5892,10 @@ static int range_is_hole_in_parent(struct send_ctx *sctx, extent_end = btrfs_file_extent_end(path); if (extent_end <= start) goto next; + if (btrfs_file_extent_type(leaf, fi) == BTRFS_FILE_EXTENT_INLINE) { + ret = 0; + goto out; + } if (btrfs_file_extent_disk_bytenr(leaf, fi) == 0) { search_start = extent_end; goto next;