media: mtk-vcodec: fix PM runtime get logic

Browse source

Currently, the driver just assumes that PM runtime logic
succeded resuming the device.

That may not be the case, as pm_runtime_get_sync()
can fail (but keeping the usage count incremented).

Replace the code to use pm_runtime_resume_and_get(),
and letting it return the error code.

This way, if mtk_vcodec_dec_pw_on() fails, the logic
under fops_vcodec_open() will do the right thing and
return an error, instead of just assuming that the
device is ready to be used.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

...

This commit is contained in:

Mauro Carvalho Chehab 2021-04-23 17:19:09 +02:00

parent 6e8b1526db

commit 908711f542

3 changed files with 9 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c

View file

8

drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c

View file

2

drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h

View file