tcp: MD5: Fix MD5 signatures on certain ACK packets

Browse source

I noticed, looking at tcpdumps, that timewait ACKs were getting sent
with an incorrect MD5 signature when signatures were enabled.

I broke this in 49a72dfb88 ("tcp: Fix
MD5 signatures for non-linear skbs"). I didn't take into account that
the skb passed to tcp_*_send_ack was the inbound packet, thus the
source and dest addresses need to be swapped when calculating the MD5
pseudoheader.

Signed-off-by: Adam Langley <agl@imperialviolet.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Adam Langley 2008-07-31 20:49:48 -07:00 • committed by David S. Miller

parent 77e2f14f71

commit 90b7e1120b

2 changed files with 4 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

net/ipv4/tcp_ipv4.c

View file

4

net/ipv6/tcp_ipv6.c

View file