drm/amdgpu/gfx: move fault and EOP IRQ get/put to hw_init/hw_fini

Browse source

priv_reg / priv_inst / bad_op and (on v11+) userq EOP IRQs are
acquired in late_init but released in hw_fini.  This split forced
gfx_v9_0_hw_fini() to defensively guard each put with
amdgpu_irq_enabled() because hw_fini runs on paths that may not
reach late_init.

amdgpu_ip_block_hw_fini() only runs after hw_init returns success,
and suspend / resume cycle the refs through the same path, so
hw_init / hw_fini pair without any extra tracking.  Move the gets
there and drop the guards.

While here, fix the pre-existing partial-failure leak in
set_userq_eop_interrupts() (gfx11 / 12_0 / 12_1).  amdgpu_irq_get()
increments the refcount before calling .set, so a failure partway
through the loop leaves earlier successful gets stranded.  Track
the loop position and roll back on the enable path.

Signed-off-by: Yunxiang Li <Yunxiang.Li@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Yunxiang Li 2026-05-27 18:05:37 -04:00 • committed by Alex Deucher

parent 115bf5ca31

commit 9117d8be85

6 changed files with 314 additions and 236 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

43

drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c

View file

162

drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c

View file

162

drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c

View file

114

drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c

View file

34

drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

View file

35

drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c

View file