drm/nouveau/kms/nv50-: Fix locking for audio callbacks

Browse source

Noticed that I wasn't paying close enough attention the last time I looked
at our audio callbacks, as I completely missed the fact that we were
figuring out which audio-enabled connector goes to each encoder by checking
it's state, but without grabbing any of the appropriate modesetting locks
to do so.

That being said however: trying to grab modesetting locks in our audio
callbacks would be very painful due to the potential for locking inversion
between HDA and DRM. So, let's instead just copy what i915 does again - add
our own audio lock to protect audio related state, and store each audio
enabled connector in each nouveau_encoder struct so that we don't need to
check any atomic states.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

...

This commit is contained in:

Lyude Paul 2020-11-13 19:14:17 -05:00 • committed by Ben Skeggs

parent b2b402789b

commit 9125e2422c

3 changed files with 43 additions and 31 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

68

drivers/gpu/drm/nouveau/dispnv50/disp.c

View file

1

drivers/gpu/drm/nouveau/nouveau_drv.h

View file

7

drivers/gpu/drm/nouveau/nouveau_encoder.h

View file