habanalabs: add return code field to module iterator

Browse source

Up until now the module iterator called void callback functions
and so caller activating callback that may fail suffered from 2 issues:
1. The need to "plant" return called in the private data. This is a
   drawback since the iterator itself should not be aware of the private
   data of the caller.
2. Due to 1 even in a failure the iterator would keep iterating instead
   of break upon error.

To overcome this an optional rc field added to the iterator context.

Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

...

This commit is contained in:

Ohad Sharabi 2022-07-13 13:47:23 +03:00 • committed by Oded Gabbay

parent 28742772a0

commit 913bd4179b

3 changed files with 32 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

drivers/misc/habanalabs/common/habanalabs.h

View file

26

drivers/misc/habanalabs/gaudi2/gaudi2.c

View file

19

drivers/misc/habanalabs/gaudi2/gaudi2_security.c

View file