diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c index 1fabc160b7d8..1c16d31f0d10 100644 --- a/drivers/gpu/drm/xe/xe_migrate.c +++ b/drivers/gpu/drm/xe/xe_migrate.c @@ -1811,11 +1811,9 @@ xe_migrate_update_pgtables_cpu_execute(struct xe_vm *vm, struct xe_tile *tile, if (pt_op->bind && !force_clear) ops->populate(tile, &update->pt_bo->vmap, - NULL, update->ofs, update->qwords, update); else ops->clear(vm, tile, &update->pt_bo->vmap, - NULL, update->ofs, update->qwords, update); } } diff --git a/drivers/gpu/drm/xe/xe_migrate.h b/drivers/gpu/drm/xe/xe_migrate.h index e6b7070134e1..94b8d8d63720 100644 --- a/drivers/gpu/drm/xe/xe_migrate.h +++ b/drivers/gpu/drm/xe/xe_migrate.h @@ -43,9 +43,6 @@ struct xe_migrate_pt_update_ops { * @populate: Populate a command buffer or page-table with ptes. * @tile: The tile for the current operation. * @map: struct iosys_map into the memory to be populated. - * @pos: If @map is NULL, map into the memory to be populated. - * @ofs: qword offset into @map, unused if @map is NULL. - * @num_qwords: Number of qwords to write. * @update: Information about the PTEs to be inserted. * * This interface is intended to be used as a callback into the @@ -53,16 +50,12 @@ struct xe_migrate_pt_update_ops { * page-tables with PTEs. */ void (*populate)(struct xe_tile *tile, struct iosys_map *map, - void *pos, u32 ofs, u32 num_qwords, const struct xe_vm_pgtable_update *update); /** * @clear: Clear a command buffer or page-table with ptes. * @vm: VM being updated * @tile: The tile for the current operation. * @map: struct iosys_map into the memory to be populated. - * @pos: If @map is NULL, map into the memory to be populated. - * @ofs: qword offset into @map, unused if @map is NULL. - * @num_qwords: Number of qwords to write. * @update: Information about the PTEs to be inserted. * * This interface is intended to be used as a callback into the @@ -70,8 +63,7 @@ struct xe_migrate_pt_update_ops { * page-tables with PTEs. */ void (*clear)(struct xe_vm *vm, struct xe_tile *tile, - struct iosys_map *map, void *pos, u32 ofs, - u32 num_qwords, + struct iosys_map *map, const struct xe_vm_pgtable_update *update); /** diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c index 666097d68563..102f40c966f1 100644 --- a/drivers/gpu/drm/xe/xe_pt.c +++ b/drivers/gpu/drm/xe/xe_pt.c @@ -1106,30 +1106,17 @@ bool xe_pt_zap_ptes_range(struct xe_tile *tile, struct xe_vm *vm, static void xe_vm_populate_pgtable(struct xe_tile *tile, struct iosys_map *map, - void *data, u32 qword_ofs, u32 num_qwords, const struct xe_vm_pgtable_update *update) { struct xe_pt_entry *ptes = update->pt_entries; - u64 *ptr = data; u32 i; - /* - * @qword_ofs is the absolute entry offset within the page table, while - * @ptes is indexed relative to @update->ofs (its first entry). The GPU - * path (write_pgtable) splits a single update into MAX_PTE_PER_SDI-sized - * chunks, calling this with an advancing @qword_ofs but a fresh @data - * pointer per chunk, so translate back into a @ptes index rather than - * assuming the chunk starts at ptes[0]. - */ - for (i = 0; i < num_qwords; i++) { - u32 idx = qword_ofs - update->ofs + i; + xe_assert(tile_to_xe(tile), map); + xe_assert(tile_to_xe(tile), !iosys_map_is_null(map)); - if (map) - xe_map_wr(tile_to_xe(tile), map, (qword_ofs + i) * - sizeof(u64), u64, ptes[idx].pte); - else - ptr[i] = ptes[idx].pte; - } + for (i = 0; i < update->qwords; i++) + xe_map_wr(tile_to_xe(tile), map, (update->ofs + i) * + sizeof(u64), u64, ptes[i].pte); } static void xe_pt_cancel_bind(struct xe_vma *vma, @@ -2021,22 +2008,22 @@ static unsigned int xe_pt_stage_unbind(struct xe_tile *tile, static void xe_migrate_clear_pgtable_callback(struct xe_vm *vm, struct xe_tile *tile, - struct iosys_map *map, void *ptr, - u32 qword_ofs, u32 num_qwords, + struct iosys_map *map, const struct xe_vm_pgtable_update *update) { u64 empty = __xe_pt_empty_pte(tile, vm, update->level); int i; - if (map && map->is_iomem) - for (i = 0; i < num_qwords; ++i) - xe_map_wr(tile_to_xe(tile), map, (qword_ofs + i) * + xe_assert(vm->xe, map); + xe_assert(vm->xe, !iosys_map_is_null(map)); + + if (map->is_iomem) + for (i = 0; i < update->qwords; ++i) + xe_map_wr(tile_to_xe(tile), map, (update->ofs + i) * sizeof(u64), u64, empty); - else if (map) - memset64(map->vaddr + qword_ofs * sizeof(u64), empty, - num_qwords); else - memset64(ptr, empty, num_qwords); + memset64(map->vaddr + update->ofs * sizeof(u64), empty, + update->qwords); } static void xe_pt_abort_unbind(struct xe_vma *vma,