usb: gadget: aspeed-vhub: Fix SETUP packets with OUT data phase

Browse source

A couple of bugs in the driver are preventing SETUP packets
with an OUT data phase from working properly.

Interestingly those are incredibly rare (RNDIS typically
uses them and thus is broken without this fix).

The main problem was an incorrect register offset being
applied for arming RX on EP0. The other problem relates
to stalling such a packet before the data phase, in which
case we don't get an ACK cycle, and get the next SETUP
packet directly, so we shouldn't reject it.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

...

This commit is contained in:

Benjamin Herrenschmidt 2018-06-28 09:01:54 +10:00 • committed by Felipe Balbi

parent 24dd9ba1c5

commit 9196b55e12

1 changed files with 8 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/usb/gadget/udc/aspeed-vhub/ep0.c

View file