net: aquantia: fix wol configuration not applied sometimes

Browse source

WoL magic packet configuration sometimes does not work due to
couple of leakages found.

Mainly there was a regression introduced during readx_poll refactoring.

Next, fw request waiting time was too small. Sometimes that
caused sleep proxy config function to return with an error
and to skip WoL configuration.
At last, WoL data were passed to FW from not clean buffer.
That could cause FW to accept garbage as a random configuration data.

Fixes: 6a7f227731 ("net: aquantia: replace AQ_HW_WAIT_FOR with readx_poll_timeout_atomic")
Signed-off-by: Nikita Danilov <nikita.danilov@aquantia.com>
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Nikita Danilov 2019-06-04 13:23:49 +00:00 • committed by David S. Miller

parent 0ee4e76937

commit 930b9a0543

2 changed files with 10 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c

View file

4

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c

View file