bnxt_en: Fix the logic that creates the health reporters.

Browse source

Fix the logic to properly check the fw capabilities and create the
devlink health reporters only when needed.  The current code creates
the reporters unconditionally as long as bp->fw_health is valid, and
that's not correct.

Call bnxt_dl_fw_reporters_create() directly from the init and reset
code path instead of from bnxt_dl_register().  This allows the
reporters to be adjusted when capabilities change.  The same
applies to bnxt_dl_fw_reporters_destroy().

Fixes: 6763c779c2 ("bnxt_en: Add new FW devlink_health_reporter")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Vasundhara Volam 2019-12-10 02:49:12 -05:00 • committed by David S. Miller

parent 0797c10d2d

commit 937f188c1f

3 changed files with 56 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

11

drivers/net/ethernet/broadcom/bnxt/bnxt.c

View file

64

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

View file

2

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h

View file