ksmbd: Compare MACs in constant time

Browse source

commit c5794709bc upstream.

To prevent timing attacks, MAC comparisons need to be constant-time.
Replace the memcmp() with the correct function, crypto_memneq().

Fixes: e2f34481b2 ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Eric Biggers 2026-03-10 12:52:14 -07:00 • committed by Greg Kroah-Hartman

parent 4af5dfb8dc

commit 93c0a22fec

3 changed files with 7 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

fs/smb/server/Kconfig

View file

4

fs/smb/server/auth.c

View file

5

fs/smb/server/smb2pdu.c

View file