Staging: batman-adv: Use kernel functions to identify broadcasts

Browse source

linux/etherdevice.h already provides functions to classify different
ethernet addresses. These inlineable functions should be used instead of
custom functions.

The check for multicast together with multicast can also be replaced
with a single test for multicast because for every ethernet address x
following is always true:

is_broadcast_ether_addr(x) => is_multicast_ether_addr(x)

or when looking more at the implementation:

(FF:FF:FF:FF:FF:FF == x) => [(01:00:00:00:00:00 & x) != 00:00:00:00:00:00]

Reported-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

...

This commit is contained in:

Sven Eckelmann 2010-11-22 00:56:07 +01:00 • committed by Greg Kroah-Hartman

parent 8cab2fbe6d

commit 951c44e0db

6 changed files with 13 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/staging/batman-adv/main.c

View file

3

drivers/staging/batman-adv/main.h

View file

16

drivers/staging/batman-adv/routing.c

View file

2

drivers/staging/batman-adv/soft-interface.c

View file

2

drivers/staging/batman-adv/unicast.c

View file

4

drivers/staging/batman-adv/vis.c

View file