ext4: drop EXT4_MF_FS_ABORTED flag

Browse source

EXT4_MF_FS_ABORTED flag has practically the same intent as
EXT4_FLAGS_SHUTDOWN flag. The shutdown flag is checked in many more
places than the aborted flag which is mostly the historical artifact
where we were relying on SB_RDONLY checks instead of the aborted flag
checks. There are only three places - ext4_sync_file(),
__ext4_remount(), and mballoc debug code - which check aborted flag and
not shutdown flag and this is arguably a bug. Avoid these
inconsistencies by removing EXT4_MF_FS_ABORTED flag and using
EXT4_FLAGS_SHUTDOWN everywhere.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230616165109.21695-5-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

...

This commit is contained in:

Jan Kara 2023-06-16 18:50:51 +02:00 • committed by Theodore Ts'o

parent 22b8d707b0

commit 95257987a6

5 changed files with 10 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

fs/ext4/ext4.h

View file

7

fs/ext4/fsync.c

View file

8

fs/ext4/inode.c

View file

4

fs/ext4/mballoc.c

View file

4

fs/ext4/super.c

View file