xprtrdma: Use xprt_pin_rqst in rpcrdma_reply_handler

Browse source

Adopt the use of xprt_pin_rqst to eliminate contention between
Call-side users of rb_lock and the use of rb_lock in
rpcrdma_reply_handler.

This replaces the mechanism introduced in 431af645cf ("xprtrdma:
Fix client lock-up after application signal fires").

Use recv_lock to quickly find the completing rqst, pin it, then
drop the lock. At that point invalidation and pull-up of the Reply
XDR can be done. Both are often expensive operations.

Finally, take recv_lock again to signal completion to the RPC
layer. It also protects adjustment of "cwnd".

This greatly reduces the amount of time a lock is held by the
reply handler. Comparing lock_stat results shows a marked decrease
in contention on rb_lock and recv_lock.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
[trond.myklebust@primarydata.com: Remove call to rpcrdma_buffer_put() from
   the "out_norqst:" path in rpcrdma_reply_handler.]
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

...

This commit is contained in:

Chuck Lever 2017-08-23 17:05:58 -04:00 • committed by Trond Myklebust

parent f9773b22a2

commit 9590d083c1

5 changed files with 19 additions and 77 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

net/sunrpc/xprt.c

View file

62

net/sunrpc/xprtrdma/rpc_rdma.c

View file

1

net/sunrpc/xprtrdma/transport.c

View file

1

net/sunrpc/xprtrdma/verbs.c

View file

30

net/sunrpc/xprtrdma/xprt_rdma.h

View file