ath9k: call ath9k_hw_detach() once upon hw init failure

Browse source

If hw initialization fails (ath9k_hw_init()) on ath_init_softc()
we bail out and call ath9k_hw_detach(). The call ath9k_hw_detach()
is conditional though as ath9k_hw_init() could itself have called
ath9k_hw_detach(). Just describing this is itself a brain twister.
Avoid this nonsense by removing ath9k_hw_detach() from ath9k_hw_init().

Upon hw initialization failure we expect the callers to take care of
the cleanup.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Luis R. Rodriguez 2009-08-03 12:24:54 -07:00 • committed by John W. Linville

parent 3ce1b1a949

commit 95fafca26d

2 changed files with 9 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

24

drivers/net/wireless/ath/ath9k/hw.c

View file

3

drivers/net/wireless/ath/ath9k/main.c

View file