net: mvneta: remove data pointer usage from device_node structure

Browse source

On year ago Rob Herring wanted to remove the data pointer from the
device_node structure[1]. The mvneta driver seemed to be the only one
which used (abused ?) it. However, the proposal of Rob to remove this
pointer from the driver introduced a regression, and I tested and fixed an
alternative way, but it was never submitted as a proper patch.

Now here it is: Instead of using the device_node structure ->data
pointer, we store the BM private data as the driver data of the BM
platform_device. The core mvneta code can retrieve it by doing a lookup
on which platform_device corresponds to the BM device tree node using
of_find_device_by_node(), and get its driver data

[1]https://www.spinics.net/lists/netdev/msg445197.html

Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Gregory CLEMENT 2018-07-18 18:10:52 +02:00 • committed by David S. Miller

parent 8466baf788

commit 965cbbec7f

3 changed files with 32 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

18

drivers/net/ethernet/marvell/mvneta.c

View file

15

drivers/net/ethernet/marvell/mvneta_bm.c

View file

5

drivers/net/ethernet/marvell/mvneta_bm.h

View file